chore: give OpenAIMixin subcalsses a change to list models without leaking _model_cache details #3682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aking _model_cache details
meta-cla
bot
added
the
CLA Signed
|
@ehhuang ptal |
mattf
requested review from
ashwinb,
bbrowning,
ehhuang,
franciscojavierarceo,
hardikjshah,
leseb,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
ashwinb
reviewed
Oct 6, 2025
| """ | ||
| return {} | ||
|
|
||
| async def get_models(self) -> Iterable[str] | None: |
There was a problem hiding this comment.
can we make this name a bit easier to understand w.r.t. the rest of the methods we have? get_ vs list_ etc? it is not very clear what the semantics of this one is immediately.
There was a problem hiding this comment.
renamed get_models -> list_provider_model_ids
leseb
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
close the _model_cache abstraction leak
Test Plan
ci w/ new tests